d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

P_SHOULDSTOP used to be p_stat == SSTOP and needed the sched_lock, now it

Browse Source 
is protected by the proc lock and doesnt' need sched_lock, so adjust the
locking appropriately.
This commit is contained in:
John Baldwin 2003-04-17 21:58:45 +00:00
parent 00e93b4d53
commit 418e9d1b9e
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=113611
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/compat/linprocfs/linprocfs.c
View File

@ -549,12 +549,13 @@ linprocfs_doprocstatus(PFS_FILL_ARGS)
struct thread *td2;
int i;
mtx_lock_spin(&sched_lock);
PROC_LOCK(p);
td2 = FIRST_THREAD_IN_PROC(p); /* XXXKSE pretend only one thread */
if (P_SHOULDSTOP(p)) {
state = "T (stopped)";
} else {
mtx_lock_spin(&sched_lock);
switch(p->p_state) {
case PRS_NEW:
state = "I (idle)";
@ -584,10 +585,9 @@ linprocfs_doprocstatus(PFS_FILL_ARGS)
state = "? (unknown)";
break;
}
mtx_unlock_spin(&sched_lock);
}
mtx_unlock_spin(&sched_lock);
PROC_LOCK(p);
fill_kinfo_proc(p, &kp);
sbuf_printf(sb, "Name:\t%s\n", p->p_comm); /* XXX escape */
sbuf_printf(sb, "State:\t%s\n", state);