d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

When setting up timewait state for a TCP connection, don't hold the

Browse Source 
socket lock over a crhold() of so_cred: so_cred is constant after
socket creation, so doesn't require locking to read.
This commit is contained in:
Robert Watson 2007-05-07 13:04:25 +00:00
parent 61d8eede29
commit 434a0d24dd
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=169347
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/netinet/tcp_subr.c
View File

@ -1811,8 +1811,8 @@ tcp_twstart(struct tcpcb *tp)
tcp_discardcb(tp); tcp_discardcb(tp);
so = inp->inp_socket; so = inp->inp_socket;
soisdisconnected(so); soisdisconnected(so);
SOCK_LOCK(so);
tw->tw_cred = crhold(so->so_cred); tw->tw_cred = crhold(so->so_cred);
SOCK_LOCK(so);
tw->tw_so_options = so->so_options; tw->tw_so_options = so->so_options;
SOCK_UNLOCK(so); SOCK_UNLOCK(so);
if (acknow) if (acknow)

2
sys/netinet/tcp_timewait.c
View File

@ -1811,8 +1811,8 @@ tcp_twstart(struct tcpcb *tp)
tcp_discardcb(tp); tcp_discardcb(tp);
so = inp->inp_socket; so = inp->inp_socket;
soisdisconnected(so); soisdisconnected(so);
SOCK_LOCK(so);
tw->tw_cred = crhold(so->so_cred); tw->tw_cred = crhold(so->so_cred);
SOCK_LOCK(so);
tw->tw_so_options = so->so_options; tw->tw_so_options = so->so_options;
SOCK_UNLOCK(so); SOCK_UNLOCK(so);
if (acknow) if (acknow)