d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use a local variable to avoid holding a lock across a call out of view

Browse Source 
Supported by:	FreeBSD Foundation
This commit is contained in:
Sam Leffler 2003-10-30 22:56:13 +00:00
parent 4a4c2efa6a
commit 457fc53d28
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=121765
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/netinet6/nd6_nbr.c
View File

@ -207,6 +207,7 @@ nd6_ns_input(m, off, icmp6len)
if (!ifa) {
struct rtentry *rt;
struct sockaddr_in6 tsin6;
int need_proxy;
bzero(&tsin6, sizeof tsin6);
tsin6.sin6_len = sizeof(struct sockaddr_in6);
@ -214,8 +215,11 @@ nd6_ns_input(m, off, icmp6len)
tsin6.sin6_addr = taddr6;
rt = rtalloc1((struct sockaddr *)&tsin6, 0, 0);
if (rt && (rt->rt_flags & RTF_ANNOUNCE) != 0 &&
rt->rt_gateway->sa_family == AF_LINK) {
need_proxy = (rt && (rt->rt_flags & RTF_ANNOUNCE) != 0 &&
rt->rt_gateway->sa_family == AF_LINK);
if (rt)
rtfree(rt);
if (need_proxy) {
/*
* proxy NDP for single entry
*/
@ -226,8 +230,6 @@ nd6_ns_input(m, off, icmp6len)
proxydl = SDL(rt->rt_gateway);
}
}
if (rt)
rtfree(rt);
}
if (!ifa) {
/*