d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not spuriously re-enable disabled io_apic pin on EOI for some configurations.

Browse Source 
If EOI suppression is supported but reported ioapic version is so old
that it does not has EOI register (weird virtualization setup), fix
Intel trick of eoi-ing by flipping pin type (edge/level) to account
for the disabled pin.

Reported by:	Juniper
Reviewed by:	jhb
Sponsored by:	The FreeBSD Foundation
MFC after:	2 weeks
Differential revision:	https://reviews.freebsd.org/D23965
This commit is contained in:
Konstantin Belousov 2020-03-18 21:34:52 +00:00
parent 1314c4920f
commit 46ed9da5fc
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=359093
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/x86/x86/io_apic.c
View File

@ -193,8 +193,11 @@ _ioapic_eoi_source(struct intsrc *isrc, int locked)
low1 |= IOART_TRGREDG | IOART_INTMSET;
ioapic_write(io->io_addr, IOAPIC_REDTBL_LO(src->io_intpin),
low1);
low1 = src->io_lowreg;
if (src->io_masked != 0)
low1 |= IOART_INTMSET;
ioapic_write(io->io_addr, IOAPIC_REDTBL_LO(src->io_intpin),
src->io_lowreg);
low1);
if (!locked)
mtx_unlock_spin(&icu_lock);
}