d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only send packet to bpf if we are committed to send it. Previously it was

Browse Source 
possible that the same packet would show up multiple times.  This poses some
constraints on the TBD locking for snc(4) (see comment).

Obtained from:	DragonFlyBSD
Submitted by:	Joerg Sonnenberger
Reviewed by:	rwatson
This commit is contained in:
Max Laier 2005-02-21 17:30:10 +00:00
parent 93d6cddf05
commit 473156220d
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=142180
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sys/dev/snc/dp83932.c
View File

@ -345,12 +345,6 @@ sncstart(ifp)
/* We need the header for m_pkthdr.len. */
M_ASSERTPKTHDR(m);
/*
* If bpf is listening on this interface, let it
* see the packet before we commit it to the wire.
*/
BPF_MTAP(ifp, m);
/*
* If there is nothing in the o/p queue, and there is room in
* the Tx ring, then send the packet directly. Otherwise append
@ -361,6 +355,16 @@ sncstart(ifp)
return;
}
/*
* If bpf is listening on this interface, let it see the packet
* before we commit it to the wire, but only if we are really
* committed to send it.
*
* XXX: Locking must protect m against premature m_freem() in
* sonictxint().
*/
BPF_MTAP(ifp, m);
sc->mtd_prev = sc->mtd_free;
sc->mtd_free = mtd_next;