d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

When an inpcb doesn't have a socket but the inpcb is passed to ipfw

Browse Source 
in the transmit path, such as TCPS_TIMEWAIT, fail the credential
extraction immediately rather than acquiring locks and looking up
the inpcb on the global lists in order to reach the conclusion that
the credential extraction has failed.

This is more efficient, but more importantly, it avoids lock
recursion on the inpcbinfo, which is no longer allowed with rwlocks.
This appears to have been responsible for at least two reported
panics.

MFC after:	3 days
Reported by:	ganbold
This commit is contained in:
Robert Watson 2008-09-27 19:28:28 +00:00
parent fd4cdfbf46
commit 47505890d6
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=183418
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/netinet/ip_fw2.c
View File

@ -1998,7 +1998,8 @@ check_uidgid(ipfw_insn_u32 *insn, int proto, struct ifnet *oif,
if (inp->inp_socket != NULL) {
fill_ugid_cache(inp, ugp);
*ugid_lookupp = 1;
}
} else
*ugid_lookupp = -1;
}
/*
* If we have already been here and the packet has no