d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make the IPsec SADB embedded route cache a union to be able to hold both the

Browse Source 
legacy and IPv6 route destination address.
Previously in case of IPv6, there was a memory overwrite due to not enough
space for the IPv6 address.

PR:		kern/122565
MFC After:	2 weeks
This commit is contained in:
Bjoern A. Zeeb 2010-10-23 20:35:40 +00:00
parent a959b1f02c
commit 4a85b5e2ea
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=214250
5 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/netinet/ip_ipsec.c
View File

@ -239,7 +239,7 @@ ip_ipsec_mtu(struct mbuf *m, int mtu)
if (sp->req != NULL &&
sp->req->sav != NULL &&
sp->req->sav->sah != NULL) {
ro = &sp->req->sav->sah->sa_route;
ro = &sp->req->sav->sah->route_cache.sa_route;
if (ro->ro_rt && ro->ro_rt->rt_ifp) {
mtu =
ro->ro_rt->rt_rmx.rmx_mtu ?

2
sys/netinet6/ip6_ipsec.c
View File

@ -366,7 +366,7 @@ ip6_ipsec_mtu(struct mbuf *m)
if (sp->req != NULL &&
sp->req->sav != NULL &&
sp->req->sav->sah != NULL) {
ro = &sp->req->sav->sah->sa_route;
ro = &sp->req->sav->sah->route_cache.sa_route;
if (ro->ro_rt && ro->ro_rt->rt_ifp) {
mtu =
ro->ro_rt->rt_rmx.rmx_mtu ?

3
sys/netipsec/ipsec_output.c
View File

@ -829,7 +829,8 @@ ipsec6_output_tunnel(struct ipsec_output_state *state, struct secpolicy *sp, int
}
ip6 = mtod(m, struct ip6_hdr *);
state->ro = &isr->sav->sah->sa_route;
state->ro =
(struct route *)&isr->sav->sah->route_cache.sin6_route;
state->dst = (struct sockaddr *)&state->ro->ro_dst;
dst6 = (struct sockaddr_in6 *)state->dst;
if (state->ro->ro_rt

8
sys/netipsec/key.c
View File

@ -2758,9 +2758,9 @@ key_delsah(sah)
/* remove from tree of SA index */
if (__LIST_CHAINED(sah))
LIST_REMOVE(sah, chain);
if (sah->sa_route.ro_rt) {
RTFREE(sah->sa_route.ro_rt);
sah->sa_route.ro_rt = (struct rtentry *)NULL;
if (sah->route_cache.sa_route.ro_rt) {
RTFREE(sah->route_cache.sa_route.ro_rt);
sah->route_cache.sa_route.ro_rt = (struct rtentry *)NULL;
}
free(sah, M_IPSEC_SAH);
}
@ -7925,7 +7925,7 @@ key_sa_routechange(dst)
SAHTREE_LOCK();
LIST_FOREACH(sah, &V_sahtree, chain) {
ro = &sah->sa_route;
ro = &sah->route_cache.sa_route;
if (ro->ro_rt && dst->sa_len == ro->ro_dst.sa_len
&& bcmp(dst, &ro->ro_dst, dst->sa_len) == 0) {
RTFREE(ro->ro_rt);

8
sys/netipsec/keydb.h
View File

@ -85,6 +85,12 @@ struct seclifetime {
u_int64_t usetime;
};
union sa_route_union {
struct route sa_route;
struct route sin_route; /* Duplicate for consistency. */
struct route_in6 sin6_route;
};
/* Security Association Data Base */
struct secashead {
LIST_ENTRY(secashead) chain;
@ -100,7 +106,7 @@ struct secashead {
/* SA chain */
/* The first of this list is newer SA */
struct route sa_route; /* route cache */
union sa_route_union route_cache;
};
struct xformsw;