d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

At the suggestion of jhb, replace atomic_set/clear calls with use of

Browse Source 
exclusive locks in the enable/disable interpreter path.

Tested with WITNESS/INVARIANTS on and off.

Reviewed by:	sson davide
This commit is contained in:
Sean Bruno 2015-06-24 15:52:26 +00:00
parent d83595b2a8
commit 4e83b32a80
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=284766
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sys/kern/imgact_binmisc.c
View File

@ -308,14 +308,14 @@ imgact_binmisc_disable_entry(char *name)
{
imgact_binmisc_entry_t *ibe;
sx_slock(&interp_list_sx);
sx_xlock(&interp_list_sx);
if ((ibe = imgact_binmisc_find_entry(name)) == NULL) {
sx_sunlock(&interp_list_sx);
sx_xunlock(&interp_list_sx);
return (ENOENT);
}
atomic_clear_32(&ibe->ibe_flags, IBF_ENABLED);
sx_sunlock(&interp_list_sx);
ibe->ibe_flags &= ~IBF_ENABLED;
sx_xunlock(&interp_list_sx);
return (0);
}
@ -329,14 +329,14 @@ imgact_binmisc_enable_entry(char *name)
{
imgact_binmisc_entry_t *ibe;
sx_slock(&interp_list_sx);
sx_xlock(&interp_list_sx);
if ((ibe = imgact_binmisc_find_entry(name)) == NULL) {
sx_sunlock(&interp_list_sx);
sx_xunlock(&interp_list_sx);
return (ENOENT);
}
atomic_set_32(&ibe->ibe_flags, IBF_ENABLED);
sx_sunlock(&interp_list_sx);
ibe->ibe_flags |= IBF_ENABLED;
sx_xunlock(&interp_list_sx);
return (0);
}