d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix an mbuf(9) leak in sendmsg() under failure condition and

Browse Source 
remove unneeded check for failed M_WAITOK allocation.

Found by: Brainy Code Scanner
Reported by: Maxime Villard
This commit is contained in:
Dmitry Chagin 2015-05-24 18:10:07 +00:00
parent 5c5aac2d45
commit 4f65e9cff4
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=283494
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/compat/linux/linux_socket.c
View File

@ -1092,8 +1092,6 @@ linux_sendmsg_common(struct thread *td, l_int s, struct l_msghdr *msghdr,
error = ENOBUFS;
cmsg = malloc(CMSG_HDRSZ, M_LINUX, M_WAITOK|M_ZERO);
control = m_get(M_WAITOK, MT_CONTROL);
if (control == NULL)
goto bad;
do {
error = copyin(ptr_cmsg, &linux_cmsg,
@ -1165,6 +1163,7 @@ linux_sendmsg_common(struct thread *td, l_int s, struct l_msghdr *msghdr,
error = linux_sendit(td, s, &msg, flags, control, UIO_USERSPACE);
bad:
m_freem(control);
free(iov, M_IOV);
if (cmsg)
free(cmsg, M_LINUX);