d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve validation of the sockaddr length in iruserok_sa().

Browse Source 
Negative numbers are not valid sockaddr lengths.

PR:		243747
Submitted by:	Andrew Reiter <areiter@veracode.com>
MFC after:	1 week
This commit is contained in:
Mark Johnston 2020-02-05 16:09:44 +00:00
parent d3631aa582
commit 51d7f2ed58
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=357575
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/libc/net/rcmd.c
View File

@ -438,8 +438,8 @@ iruserok_sa(const void *ra, int rlen, int superuser, const char *ruser,
struct sockaddr_storage ss;
/* avoid alignment issue */
if (rlen > sizeof(ss))
return(-1);
if (rlen <= 0 || rlen > sizeof(ss))
return (-1);
memcpy(&ss, ra, rlen);
raddr = (struct sockaddr *)&ss;