When booting a system with WITHOUT_IPFILTER the following errors

are encountered at boot time:

rcorder: requirement `ipfs' in file `/etc/rc.d/netif' has no providers.
rcorder: requirement `ipfilter' in file `/etc/rc.d/netif' has no
providers.
rcorder: requirement `ipfilter' in file `/etc/rc.d/netwait' has no
providers.
rcorder: requirement `ipfilter' in file `/etc/rc.d/net_watchdog' has no
providers.
rcorder: requirement `ipfilter' in file `/etc/rc.d/securelevel' has no
providers.

Listing its own requrements in BEFORE rather than use REQUIRE of
non-optional scripts resolves this issue.

The issue was discovered and patched by glebius at Netflix.

Submitted by:	glebius
Reported by:	glebius
MFC after:	1 week
This commit is contained in:
Cy Schubert 2020-08-11 23:36:38 +00:00
parent af59394536
commit 51da4b19be
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=364133
6 changed files with 5 additions and 5 deletions

View File

@ -5,6 +5,7 @@
# PROVIDE: ipfilter
# REQUIRE: FILESYSTEMS
# BEFORE: ipmon ipnat netif netwait securelevel
# KEYWORD: nojailvnet
. /etc/rc.subr

View File

@ -4,7 +4,7 @@
#
# PROVIDE: ipmon
# REQUIRE: FILESYSTEMS hostname sysctl ipfilter
# REQUIRE: FILESYSTEMS hostname sysctl
# BEFORE: SERVERS
# KEYWORD: nojailvnet

View File

@ -4,7 +4,6 @@
#
# PROVIDE: ipnat
# REQUIRE: ipfilter
# KEYWORD: nojailvnet
. /etc/rc.subr

View File

@ -27,7 +27,7 @@
# PROVIDE: netif
# REQUIRE: FILESYSTEMS iovctl serial sppp sysctl
# REQUIRE: hostid ipfilter ipfs
# REQUIRE: hostid ipfs
# KEYWORD: nojailvnet
. /etc/rc.subr

View File

@ -3,7 +3,7 @@
# $FreeBSD$
#
# PROVIDE: netwait
# REQUIRE: devd ipfilter ipfw pf routing
# REQUIRE: devd ipfw pf routing
# KEYWORD: nojail
#
# The netwait script helps handle two situations:

View File

@ -4,7 +4,7 @@
#
# PROVIDE: securelevel
# REQUIRE: adjkerntz ipfw ipfilter pf
# REQUIRE: adjkerntz ipfw pf
. /etc/rc.subr