bridge tests: Test for #216510
We used to have an issue with recursive locking with net.link.bridge.inherit_mac. This causes us to send an ARP request while we hold the BRIDGE_LOCK, which used to cause us to acquire the BRIDGE_LOCK again. We can't re-acquire it, so this caused a panic. Now that we no longer need to acquire the BRIDGE_LOCK for bridge_transmit() this should no longer panic. Test this. PR: 216510 Reviewed by: emaste, philip MFC after: 2 months Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D24251
This commit is contained in:
parent
fffd27e5f3
commit
5377560783
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=360346
@ -309,12 +309,40 @@ mac_conflict_cleanup()
|
||||
vnet_cleanup
|
||||
}
|
||||
|
||||
atf_test_case "inherit_mac" "cleanup"
|
||||
inherit_mac_head()
|
||||
{
|
||||
atf_set descr 'Bridge inherit_mac test, #216510'
|
||||
atf_set require.user root
|
||||
}
|
||||
|
||||
inherit_mac_body()
|
||||
{
|
||||
vnet_init
|
||||
|
||||
bridge=$(vnet_mkbridge)
|
||||
epair=$(vnet_mkepair)
|
||||
vnet_mkjail one ${bridge} ${epair}a
|
||||
|
||||
jexec one sysctl net.link.bridge.inherit_mac=1
|
||||
|
||||
# Attempt to provoke the panic described in #216510
|
||||
jexec one ifconfig ${bridge} 192.0.0.1/24 up
|
||||
jexec one ifconfig ${bridge} addm ${epair}a
|
||||
}
|
||||
|
||||
inherit_mac_cleanup()
|
||||
{
|
||||
vnet_cleanup
|
||||
}
|
||||
|
||||
atf_init_test_cases()
|
||||
{
|
||||
atf_add_test_case "bridge_transmit_ipv4_unicast"
|
||||
atf_add_test_case "stp"
|
||||
atf_add_test_case "static"
|
||||
atf_add_test_case "span"
|
||||
atf_add_test_case "inherit_mac"
|
||||
atf_add_test_case "delete_with_members"
|
||||
atf_add_test_case "mac_conflict"
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user