d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

snp(4): implement detach

Browse Source 
PR:	257964
Reported by:	Bertrand Petit <bsdpr@phoe.frmug.org>
Reviewed by:	imp, markj
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D36690
This commit is contained in:
Konstantin Belousov 2022-09-25 14:34:17 +03:00
parent bb4be76cf3
commit 550e01c552
2 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
share/man/man4/snp.4
View File

@ -87,9 +87,3 @@ Previous versions of
.Nm
were based on code written by
.An Ugen J.S. Antsilevich Aq Mt ugen@NetVision.net.il .
.Sh BUGS
This version of
.Nm
does not allow
.Dv SNPSTTY
to detach itself from the TTY.

15
sys/dev/snp/snp.c
View File

@ -125,6 +125,7 @@ snp_dtor(void *data)
tty_lock(tp);
ttyoutq_free(&ss->snp_outq);
ttyhook_unregister(tp);
ss->snp_tty = NULL;
}
cv_destroy(&ss->snp_outwait);
@ -252,9 +253,19 @@ snp_ioctl(struct cdev *dev, u_long cmd, caddr_t data, int flags,
case SNPSTTY:
/* Bind TTY to snoop instance. */
SNP_LOCK();
if (ss->snp_tty != NULL) {
tp = ss->snp_tty;
if (tp != NULL) {
if (*(int *)data == -1) {
tty_lock(tp);
ss->snp_tty = NULL;
ttyoutq_free(&ss->snp_outq);
ttyhook_unregister(tp);
error = 0;
} else {
error = EBUSY;
}
SNP_UNLOCK();
return (EBUSY);
return (error);
}
/*
* XXXRW / XXXJA: no capability check here.