From 57072b51183d28cc25a1b5fce0626bb5ff998e07 Mon Sep 17 00:00:00 2001 From: Edward Tomasz Napierala Date: Mon, 16 Jun 2014 19:05:51 +0000 Subject: [PATCH] Add comment explaining a potential problem with just added LUN ID. Reminded by: mav@ Sponsored by: The FreeBSD Foundation --- sys/cam/ctl/ctl_frontend_iscsi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/cam/ctl/ctl_frontend_iscsi.c b/sys/cam/ctl/ctl_frontend_iscsi.c index 260482f0254f..ed738347b973 100644 --- a/sys/cam/ctl/ctl_frontend_iscsi.c +++ b/sys/cam/ctl/ctl_frontend_iscsi.c @@ -2143,6 +2143,10 @@ cfiscsi_devid(struct ctl_scsiio *ctsio, int alloc_len) /* * desc1 is for the unique LUN name. + * + * XXX: According to SPC-3, LUN must report the same ID through + * all the ports. The code below, however, reports the + * ID only via iSCSI. */ desc1->proto_codeset = (SCSI_PROTO_ISCSI << 4) | SVPD_ID_CODESET_UTF8; desc1->id_type = SVPD_ID_PIV | SVPD_ID_ASSOC_LUN |