d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mmap_prot_3, mmap_truncate, mmap_truncate_signal: don't leak fd and map

Browse Source 
Reported by:	Coverity
CID:		978306, 1251406, 1288196, 1300541
This commit is contained in:
Enji Cooper 2017-01-04 04:10:36 +00:00
parent fad073dd44
commit 57f5b7d843
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=311244
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
contrib/netbsd-tests/lib/libc/sys/t_mmap.c
View File

@ -381,9 +381,13 @@ ATF_TC_BODY(mmap_prot_3, tc)
* the access should generate SIGSEGV.
*/
fd = open(path, O_RDWR | O_CREAT, 0700);
if (fd < 0)
#ifdef __FreeBSD__
atf_tc_skip("opening %s failed; skipping testcase: %s",
path, strerror(errno));
#else
return;
#endif
ATF_REQUIRE(write(fd, "XXX", 3) == 3);
ATF_REQUIRE(close(fd) == 0);
@ -409,6 +413,9 @@ ATF_TC_BODY(mmap_prot_3, tc)
ATF_REQUIRE(WIFEXITED(sta) != 0);
ATF_REQUIRE(WEXITSTATUS(sta) == SIGSEGV);
ATF_REQUIRE(munmap(map, 3) == 0);
#ifdef __FreeBSD__
(void)close(fd);
#endif
}
ATF_TC_CLEANUP(mmap_prot_3, tc)
@ -453,6 +460,9 @@ ATF_TC_BODY(mmap_truncate, tc)
ATF_REQUIRE(ftruncate(fd, page / 12) == 0);
ATF_REQUIRE(ftruncate(fd, page / 64) == 0);
#ifdef __FreeBSD__
(void)munmap(map, page);
#endif
ATF_REQUIRE(close(fd) == 0);
}
@ -509,6 +519,10 @@ ATF_TC_BODY(mmap_truncate_signal, tc)
prevent the access to be optimized out */
ATF_REQUIRE(i == 0);
ATF_REQUIRE(sta == 0);
#ifdef __FreeBSD__
(void)munmap(map, page);
(void)close(fd);
#endif
return;
}