d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

if_ovpn: fix mbuf leak

Browse Source 
If the link is down or we can't find a peer we do not transmit the
packet, but also don't fee it.

Remember to m_freem() mbufs we can't transmit.

Sponsored by:	Rubicon Communications, LLC ("Netgate")
This commit is contained in:
Kristof Provost 2022-07-12 14:19:25 +02:00
parent 7e06f4708c
commit 59219dde9a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/net/if_ovpn.c
View File

@ -1988,6 +1988,7 @@ ovpn_output(struct ifnet *ifp, struct mbuf *m, const struct sockaddr *dst,
if (__predict_false(ifp->if_link_state != LINK_STATE_UP)) {
OVPN_COUNTER_ADD(sc, lost_data_pkts_out, 1);
OVPN_RUNLOCK(sc);
m_freem(m);
return (ENETDOWN);
}
@ -2005,6 +2006,7 @@ ovpn_output(struct ifnet *ifp, struct mbuf *m, const struct sockaddr *dst,
/* No destination. */
OVPN_COUNTER_ADD(sc, lost_data_pkts_out, 1);
OVPN_RUNLOCK(sc);
m_freem(m);
return (ENETDOWN);
}