d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sys/arm/arm/identcpu-v4.c: fix identify_arm_cpu()

Browse Source 
identify_arm_cpu() in sys/arm/arm/identcpu-v4.c incorrectly uses a
u_int8_t variable to store the result of cpu_get_control().
It should really use a u_int variable, the same way as done for cpu_ident()
in the same function, as both cpuid and control registers are 32-bit..
This issue causes users of identcpu-v4 to incorrectly report things such as
icache status (bit 12 in cpu control register) and basically anything
defined in bits above bit 7 :-)

Reviewed by:	manu
Sponsored by:	Smartcom - Bulgaria AD
Differential Revision:	https://reviews.freebsd.org/D9460
This commit is contained in:
Stanislav Galabov 2017-02-06 14:58:24 +00:00
parent db6a9c12ba
commit 59cd18b093
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=313343
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/arm/arm/identcpu-v4.c
View File

@ -294,8 +294,7 @@ u_int cpu_pfr(int num)
void
identify_arm_cpu(void)
{
u_int cpuid;
u_int8_t ctrl;
u_int cpuid, ctrl;
int i;
ctrl = cpu_get_control();