snd_hda(4): Don't pass bogus sizeof()s to unused sysctl arg2 parameter (again)
More of the same sort of issue as r299503, just missed some sysctls added in a different place than the others. Reported by: Coverity CIDs: 1007692, 1009677, 1009678 Sponsored by: EMC / Isilon Storage Division
This commit is contained in:
parent
e6f79ac571
commit
5b81187fa9
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=299504
@ -1553,20 +1553,20 @@ hdaa_widget_parse(struct hdaa_widget *w)
|
||||
SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev),
|
||||
SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), OID_AUTO,
|
||||
buf, CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_MPSAFE,
|
||||
w, sizeof(w), hdaa_sysctl_caps, "A", "Node capabilities");
|
||||
w, 0, hdaa_sysctl_caps, "A", "Node capabilities");
|
||||
if (w->type == HDA_PARAM_AUDIO_WIDGET_CAP_TYPE_PIN_COMPLEX) {
|
||||
snprintf(buf, sizeof(buf), "nid%d_config", w->nid);
|
||||
SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev),
|
||||
SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), OID_AUTO,
|
||||
buf, CTLTYPE_STRING | CTLFLAG_RW | CTLFLAG_MPSAFE,
|
||||
&w->wclass.pin.newconf, sizeof(&w->wclass.pin.newconf),
|
||||
hdaa_sysctl_config, "A", "Current pin configuration");
|
||||
&w->wclass.pin.newconf, 0, hdaa_sysctl_config, "A",
|
||||
"Current pin configuration");
|
||||
snprintf(buf, sizeof(buf), "nid%d_original", w->nid);
|
||||
SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev),
|
||||
SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), OID_AUTO,
|
||||
buf, CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_MPSAFE,
|
||||
&w->wclass.pin.original, sizeof(&w->wclass.pin.original),
|
||||
hdaa_sysctl_config, "A", "Original pin configuration");
|
||||
&w->wclass.pin.original, 0, hdaa_sysctl_config, "A",
|
||||
"Original pin configuration");
|
||||
}
|
||||
hdaa_lock(w->devinfo);
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user