From 5c1c2e82e2275b05c7556becf58c5f97de57c990 Mon Sep 17 00:00:00 2001 From: Pawel Jakub Dawidek Date: Sun, 1 Apr 2007 13:08:05 +0000 Subject: [PATCH] I think the code I'm removing here is completely bogus. vfs_flags field is used for VFCF_* flags which are given at file system driver creation time (via VFS_SET(9)) macro. What this code did was bascially this: If file system registers itself with VFCF_UNICODE flag (stores file names as Unicode), it will gain MNT_SOFTDEP flag (UFS soft-updates). If file system registers itself with VFCF_LOOPBACK flag (aliases some other mounted FS), it will gain MNT_SUIDDIR flag (special handling of SUID on dirs). The latter will be quite dangerous, but those flags are reset later in vfs_domount(). MFC after: 1 month --- sys/kern/vfs_mount.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c index fc44e6c1045e..2f8023011857 100644 --- a/sys/kern/vfs_mount.c +++ b/sys/kern/vfs_mount.c @@ -482,9 +482,6 @@ vfs_mount_alloc(struct vnode *vp, struct vfsconf *vfsp, mp->mnt_vfc = vfsp; vfsp->vfc_refcount++; /* XXX Unlocked */ mp->mnt_stat.f_type = vfsp->vfc_typenum; - MNT_ILOCK(mp); - mp->mnt_flag |= vfsp->vfc_flags & MNT_VISFLAGMASK; - MNT_IUNLOCK(mp); mp->mnt_gen++; strlcpy(mp->mnt_stat.f_fstypename, vfsp->vfc_name, MFSNAMELEN); mp->mnt_vnodecovered = vp;