Use snprintf(3) instead of sprintf(3)
Remove useless "else"
This commit is contained in:
parent
8592cfc58e
commit
5d8ece9a4b
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=282699
@ -1018,17 +1018,16 @@ static char *
|
||||
pw_homepolicy(struct userconf * cnf, struct cargs * args, char const * user)
|
||||
{
|
||||
struct carg *arg = getarg(args, 'd');
|
||||
static char home[128];
|
||||
|
||||
if (arg)
|
||||
return arg->val;
|
||||
else {
|
||||
static char home[128];
|
||||
return (arg->val);
|
||||
|
||||
if (cnf->home == NULL || *cnf->home == '\0')
|
||||
errx(EX_CONFIG, "no base home directory set");
|
||||
sprintf(home, "%s/%s", cnf->home, user);
|
||||
return home;
|
||||
}
|
||||
if (cnf->home == NULL || *cnf->home == '\0')
|
||||
errx(EX_CONFIG, "no base home directory set");
|
||||
snprintf(home, sizeof(home), "%s/%s", cnf->home, user);
|
||||
|
||||
return (home);
|
||||
}
|
||||
|
||||
static char *
|
||||
|
Loading…
Reference in New Issue
Block a user