d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove two more 'periph == NULL' checks missed in r241404.

Browse Source 
This condition can never be true as functions are called from single place
and the checks just pollute the code and confuse Clang Static Analyzer.
This commit is contained in:
Alexander Motin 2012-10-23 16:03:00 +00:00
parent 01ef85e179
commit 5fb9dc04df
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=241952
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/cam/scsi/scsi_enc.c
View File

@ -879,11 +879,6 @@ enc_ctor(struct cam_periph *periph, void *arg)
char *tname;
cgd = (struct ccb_getdev *)arg;
if (periph == NULL) {
printf("enc_ctor: periph was NULL!!\n");
goto out;
}
if (cgd == NULL) {
printf("enc_ctor: no getdev CCB, can't register device\n");
goto out;

5
sys/cam/scsi/scsi_pt.c
View File

@ -255,11 +255,6 @@ ptctor(struct cam_periph *periph, void *arg)
struct ccb_pathinq cpi;
cgd = (struct ccb_getdev *)arg;
if (periph == NULL) {
printf("ptregister: periph was NULL!!\n");
return(CAM_REQ_CMP_ERR);
}
if (cgd == NULL) {
printf("ptregister: no getdev CCB, can't register device\n");
return(CAM_REQ_CMP_ERR);