Force the setting of bit 7 in the sysmouse packet byte 1 to be unsigned.
Clang complains about the shift of (1 << 7) into a int8_t changing the value: warning: implicit conversion from 'int' to 'int8_t' (aka 'signed char') changes value from 128 to -128 [-Wconstant-conversion] Squash this warning by forcing clang to see it as an unsigned bit. This seems odd, given that it's still a conversion of 128->-128, but I'm guessing the explicit unsigned attribute notifies clang that sign really doesn't matter in this case. Reported by: Mark Millard <markmi AT dsl-only DOT net> MFC after: 2 weeks
This commit is contained in:
parent
7f9218ef00
commit
605e7281dc
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=312977
@ -520,7 +520,7 @@ ams_read(struct cdev *dev, struct uio *uio, int flag)
|
||||
}
|
||||
}
|
||||
|
||||
sc->packet[0] = 1 << 7;
|
||||
sc->packet[0] = 1U << 7;
|
||||
sc->packet[0] |= (!(sc->buttons & 1)) << 2;
|
||||
sc->packet[0] |= (!(sc->buttons & 4)) << 1;
|
||||
sc->packet[0] |= (!(sc->buttons & 2));
|
||||
|
Loading…
Reference in New Issue
Block a user