d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

op_usm_users: don't deref uusers if it's NULL when SETting the value

Browse Source 
Add an XXX comment to note that the conditional seems suspect given
how it's handled elsewhere in the SNMP_OP_SET case.

MFC after:	2 weeks
Reported by:	Coverity
CID:		1008573
This commit is contained in:
Enji Cooper 2017-01-05 09:46:36 +00:00
parent 18d124d977
commit 60c2226f89
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=311394
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
contrib/bsnmp/snmp_usm/usm_snmp.c
View File

@ -169,8 +169,12 @@ op_usm_users(struct snmp_context *ctx, struct snmp_value *val,
val->var.subs[sub - 1] != LEAF_usmUserCloneFrom)
return (SNMP_ERR_NOSUCHNAME);
/*
* XXX (ngie): need to investigate the MIB to determine how
* this is possible given some of the transitions below.
*/
if (community != COMM_INITIALIZE &&
uuser->type == StorageType_readOnly)
uuser != NULL && uuser->type == StorageType_readOnly)
return (SNMP_ERR_NOT_WRITEABLE);
switch (val->var.subs[sub - 1]) {