Fix a dead store.

We would fail to clear DNS search list configuration if a router
stopped specifying the DNSSL RA option.  I suspect that the bug
was mostly harmless, as the RDNSS and DNSSL options are typically used
together and omitting the RDNSS option would have the same effect.

CID:		1006219
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Mark Johnston 2018-10-20 18:00:13 +00:00
parent 1f71b44df7
commit 618703b57b
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=339460

View File

@ -616,7 +616,6 @@ ra_opt_handler(struct ifinfo *ifi)
TAILQ_INSERT_TAIL(&sm_rdnss_head, smp3, TAILQ_INSERT_TAIL(&sm_rdnss_head, smp3,
sm_next); sm_next);
ifi->ifi_rdnss = IFI_DNSOPT_STATE_RECEIVED; ifi->ifi_rdnss = IFI_DNSOPT_STATE_RECEIVED;
break; break;
case ND_OPT_DNSSL: case ND_OPT_DNSSL:
if (TS_CMP(&now, &rao->rao_expire, >)) { if (TS_CMP(&now, &rao->rao_expire, >)) {
@ -656,10 +655,7 @@ ra_opt_handler(struct ifinfo *ifi)
sm_next); sm_next);
dlen += strlen(rao->rao_msg) + dlen += strlen(rao->rao_msg) +
strlen(resstr_sp); strlen(resstr_sp);
break;
ifi->ifi_dnssl = IFI_DNSOPT_STATE_RECEIVED; ifi->ifi_dnssl = IFI_DNSOPT_STATE_RECEIVED;
default:
break; break;
} }
continue; continue;