d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Note that static hints no longer break loader hints

Browse Source 
This commentary was carried over from the x86 version of the same code,
but has actually been inaccurate for a while now. As of FreeBSD 12.x,
all environments are used unless they disable each other. See
39d44f7f15 ("kern_environment: use any provided environments [...]")
for details.

Reviewed by:	imp
Differentiala Revision:	https://reviews.freebsd.org/D35695
This commit is contained in:
Kyle Evans 2023-04-26 00:38:32 -05:00
parent 3a5855dd22
commit 61fd6a1ea2
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
stand/efi/loader/arch/arm64/exec.c
View File

@ -83,11 +83,9 @@ elf64_exec(struct preloaded_file *fp)
/*
* Report the RSDP to the kernel. The old code used the 'hints' method
* to communite this to the kernel. However, while convenient, the
* 'hints' method is fragile and does not work when static hints are
* compiled into the kernel. Instead, move to setting different tunables
* that start with acpi. The old 'hints' can be removed before we branch
* for FreeBSD 15.
* to communicate this to the kernel, but this is now considered legacy.
* Instead, move to setting different tunables that start with acpi.
* The old 'hints' can be removed before we branch for FreeBSD 15.
*/
rsdp = efi_get_table(&acpi20_guid);

3
sys/arm64/acpica/OsdEnvironment.c
View File

@ -65,8 +65,7 @@ acpi_get_root_from_loader(void)
return (acpi_root);
/*
* The hints mechanism is unreliable (it fails if anybody ever
* compiled in hints to the kernel). It has been replaced
* The hints mechanism is considered legacy and has been replaced
* by the tunable method, but is used here as a fallback to
* retain maximum compatibility between old loaders and new
* kernels. It can be removed after 14.0R.