From 62f9fae610e1839b6174d73b0eb39695cc5f6a21 Mon Sep 17 00:00:00 2001
From: Poul-Henning Kamp <phk@FreeBSD.org>
Date: Thu, 24 May 2001 09:27:02 +0000
Subject: [PATCH] If the user exists abruptly, tip's "tipout" child can hang
 around forever. Since the lock file doesn't get cleaned up, this prevents
 other users from accessing the target device.

(phk adds: Man, this has been bugging me for YEARS!)

PR:		12528
Submitted by:	Craig Leres leres@ee.lbl.gov
MFC after:	1 week
---
 usr.bin/tip/tip/tip.c    | 12 ++++++++++++
 usr.bin/tip/tip/tipout.c |  3 ++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/usr.bin/tip/tip/tip.c b/usr.bin/tip/tip/tip.c
index 2b11d0b6aa0c..1f910e5cd3c5 100644
--- a/usr.bin/tip/tip/tip.c
+++ b/usr.bin/tip/tip/tip.c
@@ -81,6 +81,7 @@ int	disc = OTTYDISC;		/* tip normally runs this way */
 
 void	intprompt();
 void	timeout();
+void	killchild();
 void	cleanup();
 void	tipdone();
 char	*sname();
@@ -285,6 +286,15 @@ usage()
 	exit(1);
 }
 
+void
+killchild()
+{
+	if (pid != 0) {
+		kill(pid, SIGTERM);
+		pid = 0;
+	}
+}
+
 void
 cleanup()
 {
@@ -427,6 +437,8 @@ tipin()
 	int i;
 	char gch, bol = 1;
 
+	atexit(killchild);
+
 	/*
 	 * Kinda klugey here...
 	 *   check for scripting being turned on from the .tiprc file,
diff --git a/usr.bin/tip/tip/tipout.c b/usr.bin/tip/tip/tipout.c
index de1fe6a82251..67932f6f4045 100644
--- a/usr.bin/tip/tip/tipout.c
+++ b/usr.bin/tip/tip/tipout.c
@@ -160,7 +160,8 @@ tipout()
 		omask = sigblock(ALLSIGS);
 		for (cp = buf; cp < buf + cnt; cp++)
 			*cp &= 0177;
-		write(1, buf, cnt);
+		if (write(1, buf, cnt) < 0)
+			exit(1);
 		if (boolean(value(SCRIPT)) && fscript != NULL) {
 			if (!boolean(value(BEAUTIFY))) {
 				fwrite(buf, 1, cnt, fscript);