d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent a panic when a driver provides bogus debugnet parameters

Browse Source 
This is just a bandaid; we should fix the driver(s) too.  Introduced in
r353685.

PR:		241403
X-MFC-With:	r353685
Reported by:	np and others
This commit is contained in:
Conrad Meyer 2019-10-23 16:48:22 +00:00
parent de19b521ee
commit 65366903c3
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=353934
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/net/debugnet.c
View File

@ -826,6 +826,15 @@ debugnet_any_ifnet_update(struct ifnet *ifp)
nmbuf = ncl * (4 + nrxr);
ncl *= nrxr;
/*
* Bandaid for drivers that (incorrectly) advertise LinkUp before their
* dn_init method is available.
*/
if (nmbuf == 0 || ncl == 0 || clsize == 0) {
printf("%s: Bad dn_init result from %s (ifp %p), ignoring.\n",
__func__, if_name(ifp), ifp);
return;
}
dn_maybe_reinit_mbufs(nmbuf, ncl, clsize);
}