d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acpi_button: Replace boolean_t with better types.

Browse Source 
- Use an enum for the button type (it is not really a boolean value).

- Use bool for fixed.

Reviewed by:	imp, emaste
Differential Revision:	https://reviews.freebsd.org/D39922
This commit is contained in:
John Baldwin 2023-05-04 12:32:09 -07:00
parent 4961faaacc
commit 65c92e48c4
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/dev/acpica/acpi_button.c
View File

@ -53,10 +53,8 @@ ACPI_MODULE_NAME("BUTTON")
struct acpi_button_softc {
device_t button_dev;
ACPI_HANDLE button_handle;
boolean_t button_type;
#define ACPI_POWER_BUTTON 0
#define ACPI_SLEEP_BUTTON 1
boolean_t fixed;
enum { ACPI_POWER_BUTTON, ACPI_SLEEP_BUTTON } button_type;
bool fixed;
#ifdef EVDEV_SUPPORT
struct evdev_dev *button_evdev;
#endif
@ -120,14 +118,14 @@ acpi_button_probe(device_t dev)
} else if (strcmp(str, "ACPI_FPB") == 0) {
device_set_desc(dev, "Power Button (fixed)");
sc->button_type = ACPI_POWER_BUTTON;
sc->fixed = 1;
sc->fixed = true;
} else if (strcmp(str, "PNP0C0E") == 0) {
device_set_desc(dev, "Sleep Button");
sc->button_type = ACPI_SLEEP_BUTTON;
} else if (strcmp(str, "ACPI_FSB") == 0) {
device_set_desc(dev, "Sleep Button (fixed)");
sc->button_type = ACPI_SLEEP_BUTTON;
sc->fixed = 1;
sc->fixed = true;
}
return (rv);