d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pf: States have at least two references

Browse Source 
pf_unlink_state() releases a reference to the state without checking if
this is the last reference. It can't be, because pf_state_insert()
initialises it to two. KASSERT() that this is always the case.

CID:	1347140
This commit is contained in:
Kristof Provost 2018-01-24 04:29:16 +00:00
parent 8917c34a82
commit 6701c43213
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=328313
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/netpfil/pf/pf.c
View File

@ -1613,6 +1613,7 @@ int
pf_unlink_state(struct pf_state *s, u_int flags)
{
struct pf_idhash *ih = &V_pf_idhash[PF_IDHASH(s)];
int last;
if ((flags & PF_ENTER_LOCKED) == 0)
PF_HASHROW_LOCK(ih);
@ -1653,7 +1654,8 @@ pf_unlink_state(struct pf_state *s, u_int flags)
PF_HASHROW_UNLOCK(ih);
pf_detach_state(s);
refcount_release(&s->refs);
last = refcount_release(&s->refs);
KASSERT(last == 0, ("Incorrect state reference count"));
return (pf_release_state(s));
}