d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove residual xpt_release_device() call left after r272406 cleanup.

Browse Source 
Excessive release here could trigger use-after-free condition and kernel
panic on LUN 0 disconnect.

MFC after:	1 week
This commit is contained in:
Alexander Motin 2014-11-20 19:28:42 +00:00
parent 66cc25a224
commit 68355d6522
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=274756
1 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sys/cam/scsi/scsi_xpt.c
View File

@ -2032,23 +2032,7 @@ scsi_scan_bus(struct cam_periph *periph, union ccb *request_ccb)
scan_info->lunindex[target_id]++;
} else {
mtx_unlock(&target->luns_mtx);
/*
* We're done with scanning all luns.
*
* Nuke the bogus device for lun 0 if lun 0
* wasn't on the list.
*/
if (first != 0) {
TAILQ_FOREACH(device,
&target->ed_entries, links) {
if (device->lun_id == 0) {
break;
}
}
if (device) {
xpt_release_device(device);
}
}
/* We're done with scanning all luns. */
}
} else {
mtx_unlock(&target->luns_mtx);