d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't try to fseek before the beginning of the file; POSIX requires that

Browse Source 
this return an error.
This re-enables display of the first entry in /var/account/acct instead
 of the error "lastcomm: /var/account/acct: Invalid argument"
This commit is contained in:
Bill Fenner 2003-01-27 18:16:32 +00:00
parent 58b8fa7412
commit 6841d8b90d
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=109943
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
usr.bin/lastcomm/lastcomm.c
View File

@ -60,6 +60,8 @@ __FBSDID("$FreeBSD$");
#include <utmp.h>
#include "pathnames.h"
/*XXX*/#include <inttypes.h>
time_t expand(u_int);
char *flagbits(int);
const char *getdev(dev_t);
@ -156,13 +158,6 @@ main(int argc, char *argv[])
if (fread(&ab, sizeof(struct acct), 1, fp) != 1)
err(1, "%s", acctfile);
if (fseek(fp, 2 * -(long)sizeof(struct acct), SEEK_CUR) == -1)
err(1, "%s", acctfile);
if (size == 0)
break;
size -= sizeof(struct acct);
if (ab.ac_comm[0] == '\0') {
ab.ac_comm[0] = '?';
ab.ac_comm[1] = '\0';
@ -215,6 +210,12 @@ main(int argc, char *argv[])
(void)printf(" %.16s", ctime(&t));
}
printf("\n");
if (size == 0)
break;
size -= sizeof(struct acct);
if (fseek(fp, 2 * -(long)sizeof(struct acct), SEEK_CUR) == -1)
err(1, "%s", acctfile);
}
exit(0);
}