d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow single byte reads of the emulated MSI-X tables. This is not required

Browse Source 
by the PCI specification but needed to dump MMIO space from "ddb" in the
guest.
This commit is contained in:
Neel Natu 2013-08-27 16:50:48 +00:00
parent 6f6ebf3c3f
commit 6a52209f9c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=254965
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
usr.sbin/bhyve/pci_emul.c
View File

@ -245,8 +245,12 @@ pci_emul_msix_tread(struct pci_devinst *pi, uint64_t offset, int size)
int tab_index;
uint64_t retval = ~0;
/* support only 4 or 8 byte reads */
if (size != 4 && size != 8)
/*
* The PCI standard only allows 4 and 8 byte accesses to the MSI-X
* table but we also allow 1 byte access to accomodate reads from
* ddb.
*/
if (size != 1 && size != 4 && size != 8)
return (retval);
msix_entry_offset = offset % MSIX_TABLE_ENTRY_SIZE;
@ -263,7 +267,9 @@ pci_emul_msix_tread(struct pci_devinst *pi, uint64_t offset, int size)
dest = (char *)(pi->pi_msix.table + tab_index);
dest += msix_entry_offset;
if (size == 4)
if (size == 1)
retval = *((uint8_t *)dest);
else if (size == 4)
retval = *((uint32_t *)dest);
else
retval = *((uint64_t *)dest);