d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't do null Setattr RPCs for VA_MARK_ATIME. When we added the

Browse Source 
VA_MARK_ATIME feature to fix POSIX conformance fore execve() and mmap(),
we thought that it was optimized well enough for the one file system
that supports it (ffs) and harmless for other file systems (except
layered ones which already get the layering for VOP_SETATTR() wrong).
However, nfs_setattr() doesn't do much parameter checking, so when
it gets a combination of parameters that it doesn't understand, it
always does a Setattr RPC.  This RPC can't do anything good, and for
VA_MARK_ATIME it is null except for wasting a lot of time.

This is the smallest and easiest to fix of several bugs that have
increased the number of RPCs for kernel builds on nfs by more than
100% since 2004-11-05.  The real-time increase depends on network
latency and parallelization and can also be very large (approaching
the same percentage for unparallelized operations like "make depend"
on systems with fast CPUs and high-latency networks).
This commit is contained in:
Bruce Evans 2006-10-14 07:25:11 +00:00
parent f77d2d79f1
commit 6a72ff6b09
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=163341
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/nfsclient/nfs_vnops.c
View File

@ -668,9 +668,9 @@ nfs_setattr(struct vop_setattr_args *ap)
#endif
/*
* Setting of flags is not supported.
* Setting of flags and marking of atimes are not supported.
*/
if (vap->va_flags != VNOVAL)
if (vap->va_flags != VNOVAL || (vap->va_vaflags & VA_MARK_ATIME))
return (EOPNOTSUPP);
/*