From 6b1bc6f7dd38a5693c4000670e4179edc6dd7d5f Mon Sep 17 00:00:00 2001 From: Rick Macklem Date: Thu, 8 Aug 2019 20:07:38 +0000 Subject: [PATCH] Remove some harmless cruft from vn_generic_copy_file_range(). An earlier version of the patch had code that set "error" between line#s 2797-2799. When that code was moved, the second check for "error != 0" could never be true and the check became harmless cruft. This patch removes the cruft, mainly to make Coverity happy. Reported by: asomers, cem --- sys/kern/vfs_vnops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index e15cee41ead8..c64436e63742 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -2798,8 +2798,6 @@ vn_generic_copy_file_range(struct vnode *invp, off_t *inoffp, if (VOP_PATHCONF(invp, _PC_MIN_HOLE_SIZE, &holein) != 0) holein = 0; VOP_UNLOCK(invp, 0); - if (error != 0) - goto out; mp = NULL; error = vn_start_write(outvp, &mp, V_WAIT);