From 6ca3b02b1b5619134c0f09066511e3251315ce82 Mon Sep 17 00:00:00 2001 From: Alan Somers Date: Tue, 25 Jun 2019 18:58:51 +0000 Subject: [PATCH] fusefs: fix the tests for nondefault values of vfs.maxbcachebuf Sponsored by: The FreeBSD Foundation --- tests/sys/fs/fusefs/read.cc | 7 ++++--- tests/sys/fs/fusefs/write.cc | 15 +++++++++------ 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/tests/sys/fs/fusefs/read.cc b/tests/sys/fs/fusefs/read.cc index 5694a8f5f79f..9b2884bf17c3 100644 --- a/tests/sys/fs/fusefs/read.cc +++ b/tests/sys/fs/fusefs/read.cc @@ -163,7 +163,7 @@ TEST_F(AioRead, async_read_disabled) ssize_t bufsize = 50; char buf0[bufsize], buf1[bufsize]; off_t off0 = 0; - off_t off1 = 65536; + off_t off1 = m_maxbcachebuf; struct aiocb iocb0, iocb1; volatile sig_atomic_t read_count = 0; @@ -243,13 +243,14 @@ TEST_F(AsyncRead, async_read) ssize_t bufsize = 50; char buf0[bufsize], buf1[bufsize]; off_t off0 = 0; - off_t off1 = 65536; + off_t off1 = m_maxbcachebuf; + off_t fsize = 2 * m_maxbcachebuf; struct aiocb iocb0, iocb1; sem_t sem; ASSERT_EQ(0, sem_init(&sem, 0, 0)) << strerror(errno); - expect_lookup(RELPATH, ino, 131072); + expect_lookup(RELPATH, ino, fsize); expect_open(ino, 0, 1); EXPECT_CALL(*m_mock, process( ResultOf([=](auto in) { diff --git a/tests/sys/fs/fusefs/write.cc b/tests/sys/fs/fusefs/write.cc index 86a6831102f2..401cc04b6418 100644 --- a/tests/sys/fs/fusefs/write.cc +++ b/tests/sys/fs/fusefs/write.cc @@ -235,10 +235,13 @@ public: virtual void SetUp() { if (MAXPHYS < 2 * DFLTPHYS) GTEST_SKIP() << "MAXPHYS must be at least twice DFLTPHYS" - << "for this test"; + << " for this test"; m_async = true; m_maxwrite = MAXPHYS; WriteBack::SetUp(); + if (MAXPHYS < 2 * m_maxbcachebuf) + GTEST_SKIP() << "MAXPHYS must be at least twice maxbcachebuf" + << " for this test"; } }; @@ -619,7 +622,7 @@ TEST_F(WriteThrough, pwrite) const char RELPATH[] = "some_file.txt"; const char *CONTENTS = "abcdefgh"; uint64_t ino = 42; - uint64_t offset = 65536; + uint64_t offset = m_maxbcachebuf; int fd; ssize_t bufsize = strlen(CONTENTS); @@ -767,8 +770,8 @@ TEST_F(WriteCluster, clustering) uint64_t ino = 42; int i, fd; void *wbuf, *wbuf2x; - ssize_t bufsize = 65536; - off_t filesize = 327680; + ssize_t bufsize = m_maxbcachebuf; + off_t filesize = 5 * bufsize; wbuf = malloc(bufsize); ASSERT_NE(NULL, wbuf) << strerror(errno); @@ -814,8 +817,8 @@ TEST_F(WriteCluster, DISABLED_cluster_write_err) uint64_t ino = 42; int i, fd; void *wbuf; - ssize_t bufsize = 65536; - off_t filesize = 262144; + ssize_t bufsize = m_maxbcachebuf; + off_t filesize = 4 * bufsize; wbuf = malloc(bufsize); ASSERT_NE(NULL, wbuf) << strerror(errno);