From 6e4fcca0f87bb7d0f80934881ddd68dbd57fbcbf Mon Sep 17 00:00:00 2001 From: "Pedro F. Giffuni" Date: Mon, 18 Apr 2016 15:01:49 +0000 Subject: [PATCH] ftpd: replace malloc + memset 0 with calloc. It is faster and usually safer. Use NULL instead of zero for the pointer. --- libexec/ftpd/popen.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libexec/ftpd/popen.c b/libexec/ftpd/popen.c index 03b8f7ab5f18..5620a79596b3 100644 --- a/libexec/ftpd/popen.c +++ b/libexec/ftpd/popen.c @@ -81,9 +81,8 @@ ftpd_popen(char *program, char *type) if (!pids) { if ((fds = getdtablesize()) <= 0) return (NULL); - if ((pids = malloc(fds * sizeof(int))) == NULL) + if ((pids = calloc(fds, sizeof(int))) == NULL) return (NULL); - memset(pids, 0, fds * sizeof(int)); } if (pipe(pdes) < 0) return (NULL); @@ -185,7 +184,7 @@ ftpd_pclose(FILE *iop) * pclose returns -1 if stream is not associated with a * `popened' command, or, if already `pclosed'. */ - if (pids == 0 || pids[fdes = fileno(iop)] == 0) + if (pids == NULL || pids[fdes = fileno(iop)] == 0) return (-1); (void)fclose(iop); omask = sigblock(sigmask(SIGINT)|sigmask(SIGQUIT)|sigmask(SIGHUP));