d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Properly clear the O_NONBLOCK flag after opening the TTY.

Browse Source 
Though we should open the TTY with O_NONBLOCK to prevent rc(8) execution
from potentially stalling, we must not forget to clear the flag later
on, to prevent read(2) calls from failing later on.

This prevented the shell pathname prompt from working properly.

Reported by:	kib
This commit is contained in:
Ed Schouten 2012-04-06 13:06:01 +00:00
parent bec9e056eb
commit 6ee5808be7
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=233945
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sbin/init/init.c
View File

@ -572,9 +572,13 @@ open_console(void)
{
int fd;
/* Try to open /dev/console. */
/*
* Try to open /dev/console. Open the device with O_NONBLOCK to
* prevent potential blocking on a carrier.
*/
revoke(_PATH_CONSOLE);
if ((fd = open(_PATH_CONSOLE, O_RDWR | O_NONBLOCK)) != -1) {
(void)fcntl(fd, F_SETFL, fcntl(fd, F_GETFL) & ~O_NONBLOCK);
if (login_tty(fd) == 0)
return;
close(fd);