d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid an infinite loop by ensuring that the amount of bytes read is greater

Browse Source 
than 0 in MDXFileChunk when calculating the checksum

This edgecase can be triggered if the file is truncated while the checksum
is being calculated (i.e. the EOF is reached)

Differential Revision: https://reviews.freebsd.org/D2351 (patch by darius)
PR: 196694
Reviewed by: delphij, ngie
Submitted by: Daniel O'Connor <darius@dons.net.au>
Sponsored by: EMC / Isilon Storage Division
This commit is contained in:
Enji Cooper 2015-04-24 11:03:47 +00:00
parent 710ec77e3a
commit 6eec0f2bda
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=281928
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libmd/mdXhl.c
View File

@ -74,7 +74,7 @@ MDXFileChunk(const char *filename, char *buf, off_t ofs, off_t len)
i = read(f, buffer, sizeof(buffer));
else
i = read(f, buffer, n);
if (i < 0)
if (i <= 0)
break;
MDXUpdate(&ctx, buffer, i);
n -= i;