d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix logically dead code pointed out by clang/Coverity

Browse Source 
parse_context, parse_user_security: test for validity of results from
parse_ascii(..) with by casting to int32_t and comparing to -1; comparing
unsigned types to negative values will always be false.

Reported by: clang, Coverity
CID: 1011432, 1011433
MFC after: 3 weeks
Sponsored by: EMC / Isilon Storage Division
This commit is contained in:
Enji Cooper 2016-05-14 22:04:44 +00:00
parent 81910adfc4
commit 715e3b39a6
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=299766
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c
View File

@ -616,8 +616,8 @@ parse_context(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
warnx("Suboption 'context-engine' - no argument");
return (-1);
}
if ((snmp_client.clen = parse_ascii(val,
snmp_client.cengine, SNMP_ENGINE_ID_SIZ)) < 0) {
if ((int32_t)(snmp_client.clen = parse_ascii(val,
snmp_client.cengine, SNMP_ENGINE_ID_SIZ)) == -1) {
warnx("Bad EngineID - %s", val);
return (-1);
}
@ -655,7 +655,7 @@ parse_user_security(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
}
snmp_client.engine.engine_len = parse_ascii(val,
snmp_client.engine.engine_id, SNMP_ENGINE_ID_SIZ);
if (snmp_client.engine.engine_len < 0) {
if ((int32_t)snmp_client.engine.engine_len == -1) {
warnx("Bad EngineID - %s", val);
return (-1);
}