Don't recommend re_detach() (like in vr(4)) as another

possible method to prevent panicing in interrupt handler
after re_shutdown(), sometimes seen on SMP systems.
This would work here only because re_detach() clears
IFF_UP (to prevent another race) and it was demonstrated
that it's not enough to call vr_detach() in vr_shutdown()
to prevent a panic.
This commit is contained in:
Ruslan Ermilov 2005-09-15 19:07:10 +00:00
parent 51460da87f
commit 72293673f0
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=150178

View File

@ -2485,8 +2485,7 @@ re_shutdown(dev)
/*
* Mark interface as down since otherwise we will panic if
* interrupt comes in later on, which can happen in some
* cases. Another option is to call re_detach() instead of
* re_stop(), like ve(4) does.
* cases.
*/
sc->rl_ifp->if_flags &= ~IFF_UP;
RL_UNLOCK(sc);