d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pf: ifp can never be NULL in pfi_ifaddr_event()

Browse Source 
There's no point in the NULL check for ifp, because we'll already have
dereferenced it by then. Moreover, the event will always have a valid ifp.

Replace the late check with an early assertion.

CID:		1357338
This commit is contained in:
Kristof Provost 2018-10-23 23:15:44 +00:00
parent ad6f5f9ab5
commit 73c9014569
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=339674
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/netpfil/pf/pf_if.c
View File

@ -904,6 +904,9 @@ pfi_detach_group_event(void *arg __unused, struct ifg_group *ifg)
static void
pfi_ifaddr_event(void *arg __unused, struct ifnet *ifp)
{
KASSERT(ifp, ("ifp == NULL"));
if (ifp->if_pf_kif == NULL)
return;
@ -912,7 +915,7 @@ pfi_ifaddr_event(void *arg __unused, struct ifnet *ifp)
return;
}
PF_RULES_WLOCK();
if (ifp && ifp->if_pf_kif) {
if (ifp->if_pf_kif) {
V_pfi_update++;
pfi_kif_update(ifp->if_pf_kif);
}