Restore the writing of the .bss sections of the dsos (not the main
executable) after r190885. The whole region for the dso is mmaped with MAP_NOCORE flag, doing only mprotect(2) over .bss prevented it from writing .bss to core files. Revert the optimization of using mprotect(2) to establish .bss, overlap the section with mmap(2). Reported by: attilio Reviewed by: attilio, emaste Approved by: re (bz) MFC after: 2 weeks
This commit is contained in:
parent
1eeb6d97d0
commit
750b5e3134
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=225699
@ -215,8 +215,9 @@ map_object(int fd, const char *path, const struct stat *sb)
|
||||
bss_vlimit = round_page(segs[i]->p_vaddr + segs[i]->p_memsz);
|
||||
bss_addr = mapbase + (bss_vaddr - base_vaddr);
|
||||
if (bss_vlimit > bss_vaddr) { /* There is something to do */
|
||||
if (mprotect(bss_addr, bss_vlimit - bss_vaddr, data_prot) == -1) {
|
||||
_rtld_error("%s: mprotect of bss failed: %s", path,
|
||||
if (mmap(bss_addr, bss_vlimit - bss_vaddr, data_prot,
|
||||
data_flags | MAP_ANON, -1, 0) == (caddr_t)-1) {
|
||||
_rtld_error("%s: mmap of bss failed: %s", path,
|
||||
strerror(errno));
|
||||
return NULL;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user