d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix unused variable warning in tcp_stacks's bbr.c

Browse Source 
With clang 15, the following -Werror warning is produced:

sys/netinet/tcp_stacks/bbr.c:11925:11: error: variable 'rtr_cnt' set but not used [-Werror,-Wunused-but-set-variable]
        uint32_t rtr_cnt = 0;
                 ^

The 'rtr_cnt' variable was in bbr.c when it was first added, but it
appears to have been a debugging aid that has never been used, so remove
it.

MFC after:	3 days
This commit is contained in:
Dimitry Andric 2022-08-14 21:06:07 +02:00
parent 9762d48b7f
commit 7624896571
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/netinet/tcp_stacks/bbr.c
View File

@ -11922,7 +11922,6 @@ bbr_output_wtime(struct tcpcb *tp, const struct timeval *tv)
int32_t prefetch_so_done = 0;
int32_t prefetch_rsm = 0;
uint32_t tot_len = 0;
uint32_t rtr_cnt = 0;
uint32_t maxseg, pace_max_segs, p_maxseg;
int32_t csum_flags = 0;
int32_t hw_tls;
@ -12242,7 +12241,6 @@ bbr_output_wtime(struct tcpcb *tp, const struct timeval *tv)
goto recheck_resend;
#endif
}
rtr_cnt++;
if (rsm->r_flags & BBR_HAS_SYN) {
/* Only retransmit a SYN by itself */
len = 0;
@ -12291,7 +12289,6 @@ bbr_output_wtime(struct tcpcb *tp, const struct timeval *tv)
bbr->r_ctl.rc_tlp_send = NULL;
sack_rxmit = 1;
len = rsm->r_end - rsm->r_start;
rtr_cnt++;
if ((bbr->rc_resends_use_tso == 0) && (len > maxseg))
len = maxseg;