d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure alq's shutdown_pre_sync event handler is deregistered on module unload to

Browse Source 
avoid a dangling pointer and eventual panic on system shutdown.

Reported by:	Ali <comnetboy at gmail.com>
Tested by:	Ali <comnetboy at gmail.com>
MFC after:	1 week
This commit is contained in:
Lawrence Stewart 2013-05-24 00:49:12 +00:00
parent d013d9022a
commit 7639c9be45
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=250951
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/kern/kern_alq.c
View File

@ -99,6 +99,7 @@ static LIST_HEAD(, alq) ald_active;
static int ald_shutingdown = 0;
struct thread *ald_thread;
static struct proc *ald_proc;
static eventhandler_tag alq_eventhandler_tag = NULL;
#define ALD_LOCK() mtx_lock(&ald_mtx)
#define ALD_UNLOCK() mtx_unlock(&ald_mtx)
@ -194,8 +195,8 @@ ald_daemon(void)
ald_thread = FIRST_THREAD_IN_PROC(ald_proc);
EVENTHANDLER_REGISTER(shutdown_pre_sync, ald_shutdown, NULL,
SHUTDOWN_PRI_FIRST);
alq_eventhandler_tag = EVENTHANDLER_REGISTER(shutdown_pre_sync,
ald_shutdown, NULL, SHUTDOWN_PRI_FIRST);
ALD_LOCK();
@ -228,6 +229,8 @@ ald_shutdown(void *arg, int howto)
{
struct alq *alq;
EVENTHANDLER_DEREGISTER(shutdown_pre_sync, alq_eventhandler_tag);
ALD_LOCK();
/* Ensure no new queues can be created. */