d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mlx5: drop Giant around VSC lock and CRSPACE enumeration on attach

Browse Source 
This code practically has not sleeping points, so Giant is locked for very
long time.

Noted and reviewed by:	hselasky
MFC after:      1 week
Sponsored by:   Mellanox Technologies // NVIDIA Networking
This commit is contained in:
Konstantin Belousov 2021-07-05 12:24:00 +03:00 committed by Konstantin Belousov
parent 8391db038d
commit 78f5ebaed6
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/dev/mlx5/mlx5_core/mlx5_fwdump.c
View File

@ -81,17 +81,19 @@ mlx5_fwdump_prep(struct mlx5_core_dev *mdev)
return;
}
DROP_GIANT();
error = mlx5_vsc_find_cap(mdev);
if (error != 0) {
/* Inability to create a firmware dump is not fatal. */
mlx5_core_warn(mdev,
"Unable to find vendor-specific capability, error %d\n",
error);
return;
goto pickup_g;
}
error = mlx5_vsc_lock(mdev);
if (error != 0)
return;
goto pickup_g;
error = mlx5_vsc_set_space(mdev, MLX5_VSC_DOMAIN_SCAN_CRSPACE);
if (error != 0) {
mlx5_core_warn(mdev, "VSC scan space is not supported\n");
@ -180,6 +182,8 @@ mlx5_fwdump_prep(struct mlx5_core_dev *mdev)
unlock_vsc:
mlx5_vsc_unlock(mdev);
pickup_g:
PICKUP_GIANT();
}
int