d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fusefs: fix some memory leaks in the tests.

Browse Source 
Oddly, most of these were not detected by Coverity.

Reported by:	Coverity (one of them, anyway)
Coverity CID:	1404490
MFC after:	2 weeks
This commit is contained in:
Alan Somers 2020-02-12 18:11:07 +00:00
parent d3a5bf95f2
commit 7ee7e40976
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=357835
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/sys/fs/fusefs/read.cc
View File

@ -778,6 +778,7 @@ TEST_F(Read, cache_block)
ASSERT_EQ(bufsize, read(fd, buf, bufsize)) << strerror(errno);
ASSERT_EQ(0, memcmp(buf, contents1, bufsize));
leak(fd);
free(contents);
}
/* Reading with sendfile should work (though it obviously won't be 0-copy) */
@ -899,6 +900,8 @@ TEST_P(ReadAhead, readahead) {
ASSERT_EQ(0, memcmp(rbuf, contents, bufsize));
leak(fd);
free(rbuf);
free(contents);
}
INSTANTIATE_TEST_CASE_P(RA, ReadAhead,

5
tests/sys/fs/fusefs/write.cc
View File

@ -300,6 +300,8 @@ TEST_F(Write, append_to_cached)
/* Write the new data. There should be no more read operations */
ASSERT_EQ(BUFSIZE, write(fd, CONTENTS, BUFSIZE)) << strerror(errno);
leak(fd);
free(oldbuf);
free(oldcontents);
}
TEST_F(Write, append_direct_io)
@ -782,6 +784,8 @@ TEST_F(WriteCluster, clustering)
<< strerror(errno);
}
close(fd);
free(wbuf2x);
free(wbuf);
}
/*
@ -825,6 +829,7 @@ TEST_F(WriteCluster, DISABLED_cluster_write_err)
<< strerror(errno);
}
close(fd);
free(wbuf);
}
/*