d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Large file systems with inodes > 512K have been silently overflowing

Browse Source 
c_addr in spcl. So check before we start dumping otherwise we can
end up with a corrupted dump.

PR:		228807
Submitted by:	db
Reviewed by:	imp
Approved by:	imp
This commit is contained in:
Diane Bruce 2018-06-11 19:12:50 +00:00
parent 73b1879c2d
commit 803fec5fdf
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=334968
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sbin/dump/main.c
View File

@ -103,6 +103,7 @@ main(int argc, char *argv[])
int i, ret, anydirskipped, bflag = 0, Tflag = 0, honorlevel = 1;
int just_estimate = 0;
ino_t maxino;
int c_count=0;
char *tmsg;
spcl.c_date = _time_to_time64(time(NULL));
@ -433,7 +434,6 @@ main(int argc, char *argv[])
msgtail("to %s\n", tape);
sync();
sblock = NULL;
if ((ret = sbget(diskfd, &sblock, -1)) != 0) {
switch (ret) {
case ENOENT:
@ -453,6 +453,9 @@ main(int argc, char *argv[])
quit("TP_BSIZE (%d) is not a power of 2", TP_BSIZE);
maxino = sblock->fs_ipg * sblock->fs_ncg;
mapsize = roundup(howmany(maxino, CHAR_BIT), TP_BSIZE);
c_count = howmany(mapsize * sizeof(char), TP_BSIZE);
if (c_count > TP_NINDIR)
quit("fs is too large for dump!");
usedinomap = (char *)calloc((unsigned) mapsize, sizeof(char));
dumpdirmap = (char *)calloc((unsigned) mapsize, sizeof(char));
dumpinomap = (char *)calloc((unsigned) mapsize, sizeof(char));