d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use S_ISREG instead of manual & (also it's better to compare the

Browse Source 
result from & and the pattern instead of just assuming it's one bit
value).

Pointed out by Tianjie Mao <tjmao tjmao com>.

MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D4827
This commit is contained in:
Xin LI 2017-01-19 08:01:35 +00:00
parent 9df99d6ed0
commit 805ca1775e
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=312404
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
usr.bin/sed/main.c
View File

@ -391,7 +391,7 @@ mf_fgets(SPACE *sp, enum e_spflag spflag)
if (inplace != NULL) {
if (lstat(fname, &sb) != 0)
err(1, "%s", fname);
if (!(sb.st_mode & S_IFREG))
if (!S_ISREG(sb.st_mode))
errx(1, "%s: %s %s", fname,
"in-place editing only",
"works for regular files");