d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gcore: Don't hardcode VM write permissions.

Browse Source 
This ensures read-only PT_LOAD segments are not marked as writable in
the phdr flags.

Reviewed by:	markj
Sponsored by:	DARPA
Differential Revision:	https://reviews.freebsd.org/D35398
This commit is contained in:
John Baldwin 2022-06-06 16:43:02 -07:00
parent b831865fe3
commit 81c857dd7e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
usr.bin/gcore/elfcore.c
View File

@ -624,7 +624,9 @@ readmap(pid_t pid)
errx(1, "out of memory");
ent->start = (vm_offset_t)kve->kve_start;
ent->end = (vm_offset_t)kve->kve_end;
ent->protection = VM_PROT_READ | VM_PROT_WRITE;
ent->protection = VM_PROT_READ;
if ((kve->kve_protection & KVME_PROT_WRITE) != 0)
ent->protection |= VM_PROT_WRITE;
if ((kve->kve_protection & KVME_PROT_EXEC) != 0)
ent->protection |= VM_PROT_EXECUTE;