d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add some comments about things that have become bad as I've been

Browse Source 
working on this code, or things that I think are layering violations.
Plus a minor whitespace cleanup in one place while I'm at it.
This commit is contained in:
Warner Losh 2000-01-10 06:17:27 +00:00
parent 23a297f255
commit 82af5353b0
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=55712
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/pcic/i82365.c
View File

@ -50,6 +50,8 @@
#include <sys/kthread.h>
#include <vm/vm.h>
/* We shouldn't need to include the following, but sadly we do for now */
/* XXX */
#include <dev/pccard/pccardreg.h>
#include <dev/pccard/pccardvar.h>
@ -738,7 +740,7 @@ pcic_deactivate_card(struct pcic_handle *h)
}
static int
pcic_chip_mem_alloc(struct pcic_handle *h, bus_size_t size,
pcic_chip_mem_alloc(struct pcic_handle *h, bus_size_t size,
struct pccard_mem_handle *pcmhp)
{
bus_space_handle_t memh;

4
sys/dev/pcic/i82365var.h
View File

@ -59,9 +59,9 @@ struct pcic_handle {
int flags;
int laststate;
int memalloc;
struct pccard_mem_handle mem[PCIC_MEM_WINS];
struct pccard_mem_handle mem[PCIC_MEM_WINS]; /* XXX BAD XXX */
int ioalloc;
struct pccard_io_handle io[PCIC_IO_WINS];
struct pccard_io_handle io[PCIC_IO_WINS]; /* XXX BAD XXX */
int ih_irq;
int shutdown;